Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick: Fix volume store CLI option name in Create wizard (#251) #303

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Cherry-pick: Fix volume store CLI option name in Create wizard (#251) #303

merged 1 commit into from
Jan 17, 2018

Conversation

jak-atx
Copy link
Contributor

@jak-atx jak-atx commented Jan 16, 2018

Fix volume store CLI option name in Create wizard

Fixes #251

@cristianfalcone
Fix volume store CLI option name in Create wizard (#260)
81e33a4 
Fix volume store CLI option name in Create wizard (#251)
@jak-atx jak-atx mentioned this pull request Jan 16, 2018
Closed
@jooskim jooskim requested a review from mhagen-vmware January 16, 2018 21:38
@jak-atx
Copy link
Contributor Author

jak-atx commented Jan 16, 2018

Verified --volume-store is correct in CLI output

mhagen-vmware
mhagen-vmware approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@mhagen-vmware mhagen-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jak-atx jak-atx merged commit 40ce6ba into releases/1.3.1 Jan 17, 2018
@zjs zjs deleted the cherry/volume-store branch July 9, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhagen-vmware mhagen-vmware mhagen-vmware approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jak-atx @mhagen-vmware @vmwclabot @cristianfalcone