Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch feature/auto-vic-ui-plugin #8231

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Conversation

wjun
Copy link
Contributor

@wjun wjun commented Aug 27, 2018

Move UI plugin registration codes to vic-product

Towards: vmware/vic-product#1432

Jason Morris added 2 commits August 27, 2018 18:33
Removes vic ui code and ci rules from
this this repo for inclusion in vic-product.
Fixes vmware/vic-product#1433.
Moves lib/install/ova/ and lib/install/plugin to vic-product for
use by the fileserver plugin install. Fixes vmware/vic-product#1702
@wjun wjun requested a review from a team as a code owner August 27, 2018 11:21
@wjun wjun requested a review from zjs August 27, 2018 11:21
zjs
zjs previously requested changes Aug 27, 2018
Copy link
Member

@zjs zjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as #8219 (review)

@zjs zjs assigned wjun Aug 28, 2018
@wjun wjun dismissed zjs’s stale review August 31, 2018 06:30

The dependent PRs have been merged.

@wjun wjun merged commit fa120cc into master Aug 31, 2018
wjun added a commit to wjun/vic that referenced this pull request Aug 31, 2018
Move UI plugin registration codes to vic-product.

(cherry picked from commit fa120cc)
wjun added a commit that referenced this pull request Aug 31, 2018
Move UI plugin registration codes to vic-product.

(cherry picked from commit fa120cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants