Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch feature/auto-vic-ui-plugin #8219

Closed
wants to merge 2 commits into from
Closed

Conversation

wjun
Copy link
Contributor

@wjun wjun commented Aug 17, 2018

Move UI plugin registration codes to vic-product

Towards: vmware/vic-product#1432

Jason Morris added 2 commits August 17, 2018 10:30
Removes vic ui code and ci rules from
this this repo for inclusion in vic-product.
Fixes vmware/vic-product#1433.
Moves lib/install/ova/ and lib/install/plugin to vic-product for
use by the fileserver plugin install. Fixes vmware/vic-product#1702
@wjun wjun requested a review from a team as a code owner August 17, 2018 03:55
@wjun wjun requested review from zjs and a user August 17, 2018 04:00
Copy link
Member

@zjs zjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not seem like this can be merged until the feature branches in the other repositories have been merged; if this is merged first, the UI installer code will not exist on the master branch of any repository.

@ghost
Copy link

ghost commented Aug 21, 2018

Agree with @zjs.

Why is this being merged from a fork branch, not the repo's feature branch?

@wjun
Copy link
Contributor Author

wjun commented Aug 27, 2018

Move to the feature branch directly at #8231

@wjun wjun closed this Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants