Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove entry points for models, metrics, etc. #601

Closed
Tracked by #614
NickleDave opened this issue Dec 18, 2022 · 0 comments
Closed
Tracked by #614

Remove entry points for models, metrics, etc. #601

NickleDave opened this issue Dec 18, 2022 · 0 comments
Assignees
@NickleDave
Labels
CLN: clean / refactor code cleanup, e.g. refactoring, maintenance, typos

Comments

@NickleDave
Copy link
Collaborator

since it's annoying for dev and not used by anyone else
@NickleDave NickleDave added the CLN: clean / refactor code cleanup, e.g. refactoring, maintenance, typos label Dec 18, 2022
@NickleDave NickleDave self-assigned this Dec 18, 2022
This was referenced Jan 17, 2023
Open
Open
NickleDave added a commit that referenced this issue Feb 12, 2023
@NickleDave
CLN: Remove entry points for models, metrics. Fixes #601
65d7469 
Remove since they are basically unused
by anyone but us, but require maintenance, test, etc.

Squash commits:
- Remove vak/entry_points.py
- Remove import of entry_points from vak/__init__.py
- Remove model and metric entry points from pyproject.toml
- Rewrite models/models.py to not use entry points
- Fix use of models.find in config/validators.py
- Fix use of find in config/models.py
- Remove entry point test in
  tests/test_models/test_teenytweetynet.py
- Fix entry point test in tests/test_models/test_tweetynet.py
@NickleDave NickleDave mentioned this issue Feb 12, 2023
Closed
NickleDave added a commit that referenced this issue Feb 12, 2023
@NickleDave
MRG: #624 from vocalpy/remove-entry-points
b9d5b4b 
Remove entry points, fix #601
NickleDave added a commit that referenced this issue Feb 24, 2023
@NickleDave
CLN: Remove entry points for models, metrics. Fixes #601
b897863 
Remove since they are basically unused
by anyone but us, but require maintenance, test, etc.

Squash commits:
- Remove vak/entry_points.py
- Remove import of entry_points from vak/__init__.py
- Remove model and metric entry points from pyproject.toml
- Rewrite models/models.py to not use entry points
- Fix use of models.find in config/validators.py
- Fix use of find in config/models.py
- Remove entry point test in
  tests/test_models/test_teenytweetynet.py
- Fix entry point test in tests/test_models/test_tweetynet.py
NickleDave added a commit that referenced this issue Feb 24, 2023
@NickleDave
CLN: Remove entry points for models, metrics. Fixes #601
0a5f421 
Remove since they are basically unused
by anyone but us, but require maintenance, test, etc.

Squash commits:
- Remove vak/entry_points.py
- Remove import of entry_points from vak/__init__.py
- Remove model and metric entry points from pyproject.toml
- Rewrite models/models.py to not use entry points
- Fix use of models.find in config/validators.py
- Fix use of find in config/models.py
- Remove entry point test in
  tests/test_models/test_teenytweetynet.py
- Fix entry point test in tests/test_models/test_tweetynet.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickleDave NickleDave

Labels
CLN: clean / refactor code cleanup, e.g. refactoring, maintenance, typos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickleDave