Remove entry points, fix #601 #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove since they are basically unused by anyone but us, but require maintenance, test, etc. Squash commits: - Remove vak/entry_points.py - Remove import of entry_points from vak/__init__.py - Remove model and metric entry points from pyproject.toml - Rewrite models/models.py to not use entry points - Fix use of models.find in config/validators.py - Fix use of find in config/models.py - Remove entry point test in tests/test_models/test_teenytweetynet.py - Fix entry point test in tests/test_models/test_tweetynet.py
to hopefully get full log of failures -- not seeing them now
NickleDave
force-pushed
the
remove-entry-points
branch
from
15fad46 to
542e546
Compare
Fix two unit tests to not look for TweetyNet datasets, so they don't crash on CI - Fix tests/test_models/test_base.py unit test that tests loading state dict from path, by using `model` fixture so it only runs with teenytweetynet. - Fix tests/test_models/test_windowed_frame_classification_model.py unit test that tests definitions, by adding a MOCK_INPUT_SHAPE so we don't actually need to load a dataset to test. We really only used the dataset to get its input shape.
|
I am getting weird failures on CI, like this:
I pushed one more commit that fixed actual failures due to unit tests looking for data that's not in the generated data we download during CI runs. But I don't think that explains the exit code -9 above. Going to merge because this is passing locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.