Update to Voila 0.5.0a3 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
reviewed
Mar 23, 2023
Comment on lines
+215
to
+225
| const widgetManager = new KernelWidgetManager(kernel, rendermime); | ||
| rendermime.removeMimeType(WIDGET_MIMETYPE); | ||
| rendermime.addFactory( | ||
| { | ||
| safe: false, | ||
| mimeTypes: [WIDGET_MIMETYPE], | ||
| createRenderer: (options) => | ||
| new WidgetRenderer(options, widgetManager), | ||
| }, | ||
| -10 | ||
| ); |
There was a problem hiding this comment.
It's unclear to me why we need to do this? Why is the already registered mimetype renderer for widgets not sufficient?
There was a problem hiding this comment.
I also don't remember why we needed a custom widget manager in voici since the beginning.
There was a problem hiding this comment.
Right I am also unsure. This change mimics what is in voila-dashboards/voila#1249. But maybe there is a way to simplify all this.
There was a problem hiding this comment.
It's possible we need it because the stock @jupyter-widgets/jupyterlab-manager extension is not able to render the widgets found on the page if they don't come from a notebook (or document context).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow-up to voila-dashboards/voila#1249
Included in
voila==0.5.0a3: https://github.com/voila-dashboards/voila/releases/tag/v0.5.0a3Code changes
voila>=0.5.0a3User-facing changes
Backwards-incompatible changes
Should be none.
The custom widget manager is removed but it was not exposed before.