Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the script for bumping versions #47

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 23, 2023

References

Fixes #46

Code changes

  • Simplify the bump version script so we can specify the version directly, or next
  • Update RELEASE.md

User-facing changes

None

Backwards-incompatible changes

None

@jtpio
Copy link
Member Author

jtpio commented Mar 23, 2023

Check Release CI run looking good with the next version spec:

image

We could also tag pre-releases by entering the version directly if needed. Although for now it's fine sticking to final releases:

image

@jtpio jtpio marked this pull request as ready for review March 23, 2023 17:00
@jtpio
Copy link
Member Author

jtpio commented Mar 23, 2023

cc @martinRenou @trungleduc for awareness

@trungleduc trungleduc merged commit 9ff7f63 into voila-dashboards:main Mar 23, 2023
@trungleduc
Copy link
Member

Thanks!

@jtpio
Copy link
Member Author

jtpio commented Mar 23, 2023

I'll try making a 0.3.1 release with this and #44

@jtpio jtpio deleted the bump-version branch March 23, 2023 17:09
@martinRenou
Copy link
Member

Do you think we should do the same in Voila?

@jtpio
Copy link
Member Author

jtpio commented Mar 24, 2023

Do you think we should do the same in Voila?

I think we could yes.

Initially the script followed the way JupyterLab bumps the version to ensure the alpha -> beta -> rc -> final steps are correctly taken: voila-dashboards/voila#954

In practice for other projects it might be a bit too heavy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check correctness of the bump version script
3 participants