UpdateJob when Job annotations or labels changed

[silenceli]

bug description: #805

[TravisBuddy]

Travis tests have failed

Hey @silenceli,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 30c396e0-95c2-11ea-886e-05c348efcea1

[TravisBuddy]

Travis tests have failed

Hey @silenceli,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ffc7ffc0-95c3-11ea-886e-05c348efcea1

[TravisBuddy]

Travis tests have failed

Hey @silenceli,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6ccb1a80-95c4-11ea-886e-05c348efcea1

[k82cn]

/assign @hzxuzhonghu

[TravisBuddy]

Travis tests have failed

Hey @silenceli,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 652eff60-95cb-11ea-886e-05c348efcea1

[hzxuzhonghu]

What if other fields changed, like finalizer? You can still meet the error.

[hzxuzhonghu]

So i suggest

// no update at all
if newJob.ResourceVersion == oldJob.ResourceVersion {
    	return 
}

	if err := cc.cache.Update(newJob); err != nil {
		klog.Errorf("UpdateJob - Failed to update job <%s/%s>: %v in cache",
			newJob.Namespace, newJob.Name, err)
	}

	// NOTE: Since we only reconcile job based on Spec, we will ignore other attributes
	// For Job status, it's used internally and always been updated via our controller.
	if reflect.DeepEqual(newJob.Spec, oldJob.Spec) && newJob.Status.State.Phase == oldJob.Status.State.Phase {
		klog.V(6).Infof("Job update event is ignored since no update in 'Spec'.")
		return
	}

[silenceli]

Thx，all done

[silenceli]

Please review again, thanks~

[TravisBuddy]

Travis tests have failed

Hey @silenceli,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a0cb39a0-9673-11ea-a89a-bff82cd15392

[TravisBuddy]

Travis tests have failed

Hey @silenceli,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 03d56810-967c-11ea-a89a-bff82cd15392

[k82cn]

/approve

[hzxuzhonghu]

/lgtm

Thanks for the fix

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn, silenceli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controllers/OWNERS [hzxuzhonghu,k82cn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hzxuzhonghu]

@Thor-wl please help cherry-pick to release 0.4 branch