Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error Messages and Remove Unknown Errors #294

Closed
14 tasks done
charlespierce opened this issue Mar 8, 2019 · 0 comments
Closed
14 tasks done

Improve Error Messages and Remove Unknown Errors #294

charlespierce opened this issue Mar 8, 2019 · 0 comments

Comments

@charlespierce
Copy link
Contributor

charlespierce commented Mar 8, 2019

Tracking the progress of improving the error messages to make them more user-friendly and helpful.

Tasks

Notes

The process for updating a call to .unknown() is (as described in #249):

  1. Add a new entry to the ErrorDetails enum, including information you need for the error message if necessary.
  2. Update the match block in the impl Display for ErrorDetails block to include the error message for the new error.
  3. Update the match block in the impl NotionFail for ErrorDetails block to return the correct ExitCode for the new error.
  4. Replace any .unknown() calls that should wrap an failure in the new error with a .with_context(|error| ErrorDetails::NewError) call, setting any contextual values needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant