Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework unknown errors in platform module #338

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Rework unknown errors in platform module #338

merged 1 commit into from
Apr 12, 2019

Conversation

charlespierce
Copy link
Contributor

@charlespierce charlespierce commented Apr 8, 2019 •
edited
Loading

Closes #302

Add BuildPathError to ErrorDetails, representing being unable to join the paths when creating a virtual environment in the platform module.

@charlespierce charlespierce mentioned this pull request Apr 8, 2019
Closed
14 tasks
@charlespierce charlespierce force-pushed the rework_errors_platform branch from 62f3675 to 919613d Compare April 11, 2019 20:06
@charlespierce charlespierce marked this pull request as ready for review April 11, 2019 20:06
chriskrycho
chriskrycho approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@charlespierce charlespierce merged commit 177322a into volta-cli:master Apr 12, 2019
@charlespierce charlespierce deleted the rework_errors_platform branch April 12, 2019 03:15
@rwjblue rwjblue mentioned this pull request May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update calls to .unknown() in platform module
2 participants
@charlespierce @chriskrycho