Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework unknown errors in event module #337

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Rework unknown errors in event module #337

merged 1 commit into from
Apr 11, 2019

Conversation

charlespierce
Copy link
Contributor

@charlespierce charlespierce commented Apr 8, 2019 •
edited
Loading

Closes #297

Update the tests in the event module to not use the .unknown() method and instead instantiate an ErrorDetails object.

@charlespierce charlespierce changed the title Rework errors event Rework unknown call in event module Apr 8, 2019
@charlespierce charlespierce changed the title Rework unknown call in event module Rework unknown errors in event module Apr 8, 2019
@charlespierce charlespierce mentioned this pull request Apr 8, 2019
Closed
14 tasks
@charlespierce charlespierce marked this pull request as ready for review April 11, 2019 20:06
@chriskrycho
Copy link
Contributor

:shipit:

@charlespierce charlespierce merged commit b7efa60 into volta-cli:master Apr 11, 2019
@charlespierce charlespierce deleted the rework_errors_event branch April 11, 2019 21:05
@rwjblue rwjblue mentioned this pull request May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlespierce @chriskrycho