Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework unknown errors in event module #337

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Rework unknown errors in event module #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/notion-core/src/event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,9 @@ impl EventLog {
pub mod tests {

use super::EventLog;
use crate::error::ErrorDetails;
use crate::session::ActivityKind;
use notion_fail::{ExitCode, FailExt};
use std::io;
use notion_fail::ExitCode;

#[test]
fn test_adding_events() {
Expand All @@ -163,7 +163,7 @@ pub mod tests {
assert_eq!(event_log.events.len(), 3);
assert_eq!(event_log.events[2].name, "version");

let error = io::Error::new(io::ErrorKind::Other, "test!").unknown();
let error = ErrorDetails::NoGlobalInstalls.into();
event_log.add_event_error(ActivityKind::Install, &error);
assert_eq!(event_log.events.len(), 4);
assert_eq!(event_log.events[3].name, "install");
Expand Down