-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 3.0.0 #58
Conversation
Currently the tests fail. I'd like to release with passing tests but won't have time to fix it for the next days. |
I've merged #59 now. I'd be great if you could rebase this. |
9a4ee77
to
ee178dd
Compare
It looks like there is some instability in Travis right now (see https://travis-ci.org/voxpupuli/librarian-puppet/jobs/324492300). I'm going to try to remove some old versions to reduce the size of the matrix, in the hope that this makes a successful build more likely. |
Ruby 2.1 and earlier and Puppet 3.8 and earlier are no longer supported (and haven't been for a year or longer). I think there's no reason to continue testing releases before that. |
I had a very similar patch. Since you're adding puppet 5 to the matrix, it might make sense to add it to Line 15 in 3a53296
|
Btw, I'm fine with continuing to iterate here for now but for the changelog it'll be cleaner if we merge a separate "Update the testing matrix PR". We can do that once the build is green. |
And #60 might also make sense to include. |
Travis CI seems to be having problems with network connectivity and processes randomly crashing at the moment. I'll try again in a couple of hours. |
I've seen a lot of issues on Travis with timeouts recently, even on builds that just had a matrix of 4. Not sure you can do a lot about that right now :( |
Hope springs eternal :-) It's only two of about 40 builds that fails, so I keep hoping I'll get enough of the working Docker hosts to complete a build. Considering the Travis problems, do you feel comfortable pushing the release even though the tests are seemingly failing? |
I can restart individual failing jobs so that gives a lot more chance than the bulk restart. Other than that I'd be confident if just 1 or 2 fail due to network issues since I've seen plenty of passing jobs already. |
Should I squash the changes to clean up this PR? Or are you happy the way it is? |
I'd prefer a squashed commits. Could you open that as a separate PR, especially since it adds Puppet 5 support. We can then include that in the changelog and keep this as a simple release-only PR. |
c6ad398
to
dee849a
Compare
I've openen PR #61 and rebased this PR on it. |
dee849a
to
cdf5f2e
Compare
So, finally this can be merged and tagged? Or is there anything left you'd like me to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is almost done now. Thanks for all the hard work so far!
Changelog.md
Outdated
@@ -2,6 +2,18 @@ | |||
|
|||
## From 2.x Librarian-Puppet requires Ruby >= 1.9, uses Puppet Forge API v3. For Ruby 1.8 use 1.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're no longer testing with 1.9, should we officially drop it and make it a 3.0? I've seen builds pass with this so I'd be happy with leaving it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's sending the right message. Let me update the message and the version.
Changelog.md
Outdated
@@ -2,6 +2,18 @@ | |||
|
|||
## From 2.x Librarian-Puppet requires Ruby >= 1.9, uses Puppet Forge API v3. For Ruby 1.8 use 1.x | |||
|
|||
### 2.2.4 | |||
|
|||
* [PR #1](https://github.com/voxpupuli/librarian/pull/1) Add support for r10k Puppetfile's opts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature makes it 2.3.0 I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll bump to 3.0.0
cdf5f2e
to
cf325b9
Compare
I've bumped to 3.0.0 and added a description to the changelog and readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the gemspec required version too?
librarian-puppet/librarian-puppet.gemspec
Lines 18 to 19 in ee4261b
# puppet_forge gem requires ruby 1.9 so we do too, use version 1.x in ruby 1.8 | |
s.required_ruby_version = '>= 1.9.0' |
Changelog.md
Outdated
* [PR #59](https://github.com/voxpupuli/librarian-puppet/pull/59) Fix tests | ||
* [PR #61](https://github.com/voxpupuli/librarian-puppet/pull/61) Bring testing matrix up to date | ||
|
||
### 2.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this section?
9654cf6
to
12f169a
Compare
How does this look now? |
I'd appreciate if someone else could have a look as well so I'll leave this open till the end of the week. |
The removal of Puppet versions prior to 3.8 and Ruby versions prior to 1.9 is a breaking change warranting a major version bump.
12f169a
to
e854065
Compare
@ekohl how do you feel about merging this? |
@stefanbethke I didn't get to it due to other activities last week but I think I'm good with it. Thanks a lot for the effort! If you want to get involved more, I'd be happy to help you get on board. |
See Changelog.md for details.
As part of the release, adjust testing matrix to recent versions of Ruby and Puppet. Puppet 3.8 does not support Ruby 2.2 or newer, so these combinations are excluded from the testing matrix.