Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 3.0.0 #58

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Conversation

stefanbethke
Copy link

@stefanbethke stefanbethke commented Dec 20, 2017

See Changelog.md for details.

As part of the release, adjust testing matrix to recent versions of Ruby and Puppet. Puppet 3.8 does not support Ruby 2.2 or newer, so these combinations are excluded from the testing matrix.

@ekohl
Copy link
Member

ekohl commented Dec 26, 2017

Currently the tests fail. I'd like to release with passing tests but won't have time to fix it for the next days.

@stefanbethke stefanbethke mentioned this pull request Jan 2, 2018
@stefanbethke
Copy link
Author

Should I merge #59 into this PR, or do you want to merge #59 first, @ekohl?

@ekohl
Copy link
Member

ekohl commented Jan 3, 2018

I've merged #59 now. I'd be great if you could rebase this.

@stefanbethke
Copy link
Author

It looks like there is some instability in Travis right now (see https://travis-ci.org/voxpupuli/librarian-puppet/jobs/324492300).

I'm going to try to remove some old versions to reduce the size of the matrix, in the hope that this makes a successful build more likely.

@stefanbethke
Copy link
Author

Ruby 2.1 and earlier and Puppet 3.8 and earlier are no longer supported (and haven't been for a year or longer). I think there's no reason to continue testing releases before that.

@ekohl
Copy link
Member

ekohl commented Jan 3, 2018

I had a very similar patch. Since you're adding puppet 5 to the matrix, it might make sense to add it to

tags = (2..4).select {|i| i != puppet_version}.map{|i| "--tags @puppet#{puppet_version},~@puppet#{i}"}
as well.

@ekohl
Copy link
Member

ekohl commented Jan 3, 2018

Btw, I'm fine with continuing to iterate here for now but for the changelog it'll be cleaner if we merge a separate "Update the testing matrix PR". We can do that once the build is green.

@ekohl
Copy link
Member

ekohl commented Jan 3, 2018

And #60 might also make sense to include.

@stefanbethke
Copy link
Author

Travis CI seems to be having problems with network connectivity and processes randomly crashing at the moment. I'll try again in a couple of hours.

@ekohl
Copy link
Member

ekohl commented Jan 4, 2018

I've seen a lot of issues on Travis with timeouts recently, even on builds that just had a matrix of 4. Not sure you can do a lot about that right now :(

@stefanbethke
Copy link
Author

Hope springs eternal :-) It's only two of about 40 builds that fails, so I keep hoping I'll get enough of the working Docker hosts to complete a build.

Considering the Travis problems, do you feel comfortable pushing the release even though the tests are seemingly failing?

@ekohl
Copy link
Member

ekohl commented Jan 4, 2018

I can restart individual failing jobs so that gives a lot more chance than the bulk restart. Other than that I'd be confident if just 1 or 2 fail due to network issues since I've seen plenty of passing jobs already.

@stefanbethke
Copy link
Author

Should I squash the changes to clean up this PR? Or are you happy the way it is?

@ekohl
Copy link
Member

ekohl commented Jan 4, 2018

I'd prefer a squashed commits. Could you open that as a separate PR, especially since it adds Puppet 5 support. We can then include that in the changelog and keep this as a simple release-only PR.

@stefanbethke
Copy link
Author

stefanbethke commented Jan 4, 2018

I've openen PR #61 and rebased this PR on it.

@stefanbethke
Copy link
Author

So, finally this can be merged and tagged? Or is there anything left you'd like me to do?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is almost done now. Thanks for all the hard work so far!

Changelog.md Outdated
@@ -2,6 +2,18 @@

## From 2.x Librarian-Puppet requires Ruby >= 1.9, uses Puppet Forge API v3. For Ruby 1.8 use 1.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're no longer testing with 1.9, should we officially drop it and make it a 3.0? I've seen builds pass with this so I'd be happy with leaving it in.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's sending the right message. Let me update the message and the version.

Changelog.md Outdated
@@ -2,6 +2,18 @@

## From 2.x Librarian-Puppet requires Ruby >= 1.9, uses Puppet Forge API v3. For Ruby 1.8 use 1.x

### 2.2.4

* [PR #1](https://github.com/voxpupuli/librarian/pull/1) Add support for r10k Puppetfile's opts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature makes it 2.3.0 I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bump to 3.0.0

@stefanbethke stefanbethke changed the title Prepare release 2.2.4 Prepare release 3.0.0 Jan 4, 2018
@stefanbethke
Copy link
Author

I've bumped to 3.0.0 and added a description to the changelog and readme.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the gemspec required version too?

# puppet_forge gem requires ruby 1.9 so we do too, use version 1.x in ruby 1.8
s.required_ruby_version = '>= 1.9.0'

Changelog.md Outdated
* [PR #59](https://github.com/voxpupuli/librarian-puppet/pull/59) Fix tests
* [PR #61](https://github.com/voxpupuli/librarian-puppet/pull/61) Bring testing matrix up to date

### 2.2.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this section?

@stefanbethke stefanbethke force-pushed the release/2.2.4 branch 2 times, most recently from 9654cf6 to 12f169a Compare January 10, 2018 08:53
@stefanbethke
Copy link
Author

How does this look now?

@ekohl
Copy link
Member

ekohl commented Jan 10, 2018

I'd appreciate if someone else could have a look as well so I'll leave this open till the end of the week.

The removal of Puppet versions prior to 3.8 and Ruby versions prior to
1.9 is a breaking change warranting a major version bump.
@stefanbethke
Copy link
Author

@ekohl how do you feel about merging this?

@ekohl
Copy link
Member

ekohl commented Jan 15, 2018

@stefanbethke I didn't get to it due to other activities last week but I think I'm good with it. Thanks a lot for the effort! If you want to get involved more, I'd be happy to help you get on board.

@ekohl ekohl merged commit 64ebfcf into voxpupuli:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants