Bring testing matrix up to date #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
|
In my opinion it is fine to drop Puppet 3.X testing and ruby 2.0, both are EOL since a long long time. This will also reduce the travis runtime/matrix. |
|
@ekohl How do you feel about Puppet 3.8 and Ruby 2.0? I'm happy to drop it. |
|
At $employer we still have a downstream project that includes support for puppet 3 and runs on Ruby 2.0. Yay long support cycles. Since it still works I strongly prefer to support it :) |
|
OK, happy to leave it in; we do have a few legacy projects here that are on 3.8 as well. Anything else to be done to get this merged, and 2.2.4 released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Puppet 5, remove really old versions.