Use custom_jails parameter #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Dec 17, 2018
ekohl
approved these changes
Dec 17, 2018
dhollinger
reviewed
Dec 17, 2018
| if $config_custom_jails { | ||
| create_resources('fail2ban::jail', $config_custom_jails) | ||
| } | ||
| create_resources('fail2ban::jail', $::fail2ban::custom_jails) |
There was a problem hiding this comment.
Aren't the leading :: on a variable considered bad practice?
There was a problem hiding this comment.
Bad practice is overstating it IMHO. They are needed in Puppet 3 to match Puppet 4+ behavior without them. With it's always absolute. Given the rest of the module is still using the absolute version I'd prefer consistency over the modern way.
Dan33l
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #99