Refactor manifests #798
Refactor manifests #798
Conversation
* Update header for puppet-strings * Assert that class is private * Remove useless variables
* Update header for puppet-strings * Assert that class is private * Remove useless variables
* Update header for puppet-strings * Assert that class is private
* Update header for puppet-strings * Assert that class is private * Remove useless variables * Use groupname instead of gid * Make class more readable
|
#781 has some more info about the keys. I like the suggestion to just bake the files directly into the module; this is probably the most secure option. |
|
Also, I don’t have a preference on mirror, but packagecloud has their erlang packages too: |
Yes, but they only provide Erlang packages for RedHat/CentOS. |
Yes, but I do not know if we just need to provide the latest GPG key. My understanding was that they resigned all packages with the current GPG key. |
|
@dhoppe can you please rebase? |
|
@dhoppe do you want to work on this some more? I probably should cut a major release soon, and it would be nice to include these changes if you're able to update them. |
|
Dear @dhoppe, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
@dhoppe I'm going to close this one for now; feel free to reopen / revisit when you're ready to work on this again. |
The following classes still have to be refactored:
The classes
apt.ppandrhel.ppdepend on pr #797.I also need to know which Mirror we want to use as default and change the GPG key. I would like to use Bintray, because it provides packages for Erlang.
Because of the many changes to the code we will have to release a major release anyway.