Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.0.0 + modulesync #820

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Release 10.0.0 + modulesync #820

merged 2 commits into from
Dec 2, 2019

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Dec 2, 2019 •
edited
Loading

Pull Request (PR) description

BREAKING CHANGE: Drop Ubuntu 14.04 support (#818)

This Pull Request (PR) fixes the following issues

Fixes #817

@wyardley wyardley requested review from bastelfreak and ekohl December 2, 2019 17:52
bastelfreak
bastelfreak previously approved these changes Dec 2, 2019
View reviewed changes
ekohl
ekohl reviewed Dec 2, 2019
View reviewed changes
@bastelfreak bastelfreak dismissed their stale review December 2, 2019 17:57

pressed wrong button

@ekohl
Copy link
Member

ekohl commented Dec 2, 2019

Given this is breaking, should it also merge #796 to avoid doing too many breaking changes? Perhaps there are more.

@wyardley
Copy link
Contributor Author

wyardley commented Dec 2, 2019 •
edited
Loading

Given this is breaking, should it also merge #796 to avoid doing too many breaking changes?
Perhaps there are more.

I'm not sure #796 is breaking, but I also don't think it's the right behavior still.

@dhoppe didn't respond to some of the comments there, but I think there should be a fix that's a bit narrower and still resolves this issue?

#798 should ideally go out as a major, but I don't think it's ready...

@wyardley
Copy link
Contributor Author

wyardley commented Dec 2, 2019

Since modulesync isn't in its own PR, I shouldn't add the modulesync label, right?

@wyardley
Copy link
Contributor Author

wyardley commented Dec 2, 2019

@ekohl @bastelfreak I never got feedback on #785, but I think that one would be backwards-incompatible... from a security standpoint, this one is probably a good one to release, even though it changes behavior... however, because of the change of order, I think it could cause a reload of configs?

@bastelfreak
Copy link
Member

I approved #785. Please also run bundle exec rake reference to ensure that the REFERENCE.md is up2date.

@wyardley
Copy link
Contributor Author

wyardley commented Dec 2, 2019

Thanks @bastelfreak!

@wyardley
Release 10.0.0
0180830 
- Drop Ubuntu 14.04 support
- Extend version regex for RabbitMQ 3.8
- Clean up acceptance spec helper
@wyardley
Update from voxpupuli modulesync_config
76ddcad
@wyardley
Copy link
Contributor Author

wyardley commented Dec 2, 2019

@ekohl @bastelfreak: Updated changelog. Reference seems up-to-date.

@wyardley wyardley requested review from ekohl and bastelfreak December 2, 2019 21:13
@bastelfreak bastelfreak changed the title Release 10.0.0 Release 10.0.0 + modulesync Dec 2, 2019
@wyardley wyardley merged commit 9e74ded into voxpupuli:master Dec 2, 2019
@wyardley wyardley deleted the wyardley-10_0_0 branch December 2, 2019 21:18
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
@wyardley
Merge pull request voxpupuli#820 from wyardley/wyardley-10_0_0
4dc325a 
Release 10.0.0 + modulesync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@ekohl ekohl Awaiting requested review from ekohl

Assignees
No one assigned
Labels
modulesync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version release
3 participants
@wyardley @ekohl @bastelfreak