Upstream v1.3.5 merge #17
Conversation
* Fix multi saml strategy race conditions node-saml#425 * Add warning for MultiSaml in Readme
This reverts commit f64cc7a.
* Return XML object for AttributeValue if not a string * Test XML-valued AttributeValue returns object
Bumps [acorn](https://github.com/acornjs/acorn) from 7.1.0 to 7.4.0. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@7.1.0...7.4.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.20) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fix duplicate bug report templates.
* upstream: docs: remove badges broken by project rename. bump version to 1.3.5 deps: really bump xml-encryption for node-forge sub-dep upgrade to address vuln. docs: Update package.json / README to reflect site move. deps: bump xml-encryption to address node-forge sub-dep vuln. Update issue templates Update issue templates Bump lodash from 4.17.15 to 4.17.20 (node-saml#449) Bump acorn from 7.1.0 to 7.4.0 (node-saml#448) Return object for XML-valued AttributeValues (node-saml#447) Revert "doc: announce site move." (node-saml#446) doc: announce site move. add yarn-error.log to .gitignore bump version. Fix multi saml strategy race conditions (node-saml#426) v1.3.3 v1.3.2 # Conflicts: # .gitignore # README.md # package.json
… work with Suomifi related functionality
|
The checks are failing because upstream yarn.lock has [email protected] which expects node >=10. Chalk 4.10 comes from inquirer which comes from eslint 6.5.1. Upstream has removed Travis CI build so I think they're not yet aware of the problem. Upstream supports oldest LTS release of Node (https://github.com/node-saml/passport-saml/releases/tag/v1.3.0) which is now Node 10 I think. "error [email protected]: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.10.0"" |
|
Waiting for removing EOL Node 8 support in upstream: node-saml#462 |
|
[node-saml#462] seems to be merged, which is nice. |
* master: update xmldom to 0.5.x, debug to ^4.3.1, xml-encryption to ^1.2.0 and node >= 10 update xml-crypto to 2.0.0 bump the version also in the same PR mainline passport-saml has dropped the 'options' from the generateLogoutRequest function call, which means that options.vetumaLang gets dropped and the logoutrequest no longer has vetuma-extension. This in turn means that Single Logout page won't be localized correctly.
|
Merged the changes from 1.3.3-sfi.3 to this branch which fixes the blocking issues with Node 8 support in upstream. Upstream has then moved to TypeScript (from v1.4.0 upwards) so for now didn't update the branch to v1.4.0 upstream. |
|
I'll decline/close this PR. Gained benefit is not much (changes https://github.com/node-saml/passport-saml/releases/tag/v1.3.5). We are trying to get away from this fork and move to use upstream 'passport-saml' because it currently has almost all features which this fork has offered. |
Merge changes done in passport-saml until v1.3.5 tag.