Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression in new CRAN release? #114

Closed
MichaelChirico opened this issue Feb 18, 2022 · 7 comments
Closed

Possible regression in new CRAN release? #114

MichaelChirico opened this issue Feb 18, 2022 · 7 comments
Labels

Comments

@MichaelChirico
Copy link
Contributor

As reported in Rdatatable/data.table#5339

There's an apparent change of behavior that may be a bug. Not clear if working as intended and I don't see anything obviously related in the ChangeLog:

r-yaml/inst/CHANGELOG

Lines 1 to 26 in 969ee12

### Release Notes
v2.3.4
- Added read_yaml parameter readLines.warn that defaults to TRUE for overrriding warnings about incomplete files.
v2.3.3
-Fixed Bug #99, support for BUILTINSXP functions as handlers
v2.3.2
- Removed some code that got revert in the libyaml 0.2.5 merge at 2.2.4 release
v2.3.1
- Added omap support for output using proper tag.
v2.3.0
- Made eval.expr default to FALSE
v2.2.4
- Updated libyaml code from 0.2.5
v2.2.3
- Added attribute quote support for strings #72 #109
v2.2.2
- change maintainer from Jeremy Stephens to Shawn Garbett
- move Git repository to https://github.com/vubiostat/r-yaml

writeLines(yaml::as.yaml(list(eol = "\n", a = 1), line.sep = "\n"))
# eol: |2+
# 
# a: 1.0
# ...

Note the new .... Note that a = 1 is not necessary to trigger the ..., but helps illustrate that the ... always comes at the end, regardless of other keys in the input.

@spgarbet
Copy link
Member

I am trying to move the package to using the current version of libyaml in an unmodified state. The issue is introduced in change aedd27c.

@MichaelChirico
Copy link
Contributor Author

Thanks! glad it appears fixed! Can we inform CRAN there'll be a patched release for yaml sometime in the near future?

@spgarbet
Copy link
Member

I just submitted it. Your clear test case made short work of it.

@MichaelChirico
Copy link
Contributor Author

excellent, thanks for the quick turnaround!!

@spgarbet
Copy link
Member

Np. I'm surprised the test cases didn't catch this one. At least there's a new test.

@MichaelChirico
Copy link
Contributor Author

it happens. feel free to test against our suite as well in the future. it's in a weird gap in CRAN policies because we only Suggest yaml so there's no enforcement except when something like this happens. I think devtools will run against suggests in their revdep tooling, if you're using that

@spgarbet
Copy link
Member

The new version is up on CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants