Skip to content
This repository has been archived by the owner on Jul 26, 2021. It is now read-only.

apply and translate vitejs/vite@de1ddd4 #174

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Conversation

jay-es
Copy link
Member

@jay-es jay-es commented Jun 26, 2021

close #169

399879cvitejs/vite@de1ddd4 を取り込み、
b6bbbbd で翻訳しています

when XXX is about to - がいくつかありましたが、直訳だと回りくどかったので「直前」としました。
(ニュアンス合ってるでしょうか)

guide/api-hmr.md Outdated Show resolved Hide resolved
Copy link
Member

@naokie naokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beforeXXX なので「直前」でも意味はあってますし、単純に和訳して「〜のとき」 でもよいと思います。

Co-authored-by: Naoki Endoh <[email protected]>
@jay-es jay-es requested a review from naokie June 29, 2021 11:15
Copy link
Member

@naokie naokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

もう1箇所あったのでコメントしました。

guide/api-hmr.md Outdated Show resolved Hide resolved
Co-authored-by: Naoki Endoh <[email protected]>
@jay-es jay-es requested a review from naokie June 29, 2021 13:19
Copy link
Member

@naokie naokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naokie naokie merged commit 2ca152b into vuejs-jp:main Jun 30, 2021
@jay-es jay-es deleted the issue169 branch June 30, 2021 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add client events to import.meta.hot.on
2 participants