-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyress e2e plugin generates _eslintrc.js instead of .eslintrc.js #2424
Comments
Can't reproduce on Node 10.8.0/linux |
I will do more tests later today. Going to make a custom local plugin to check if it's OS dependent or something. |
Did you try with an more recent version? BTW, node 9.x shouldn't really be used, it's a development branch. |
OK so I tried again, updated node, same results. However, when creating custom plugin, with a file with underscore as first char, I dont see the problem. Versions: |
I played around with creating custom plugins, cloning the cli locally. What I gathered is this:
This is both with custom plugins and augmenting the shipped cypress one. Should I delve deeper into this? I will try tomorrow with a fresh Windows 10 install just in case. |
I think I found the culprit. Globby returns paths with forward slash on Windows, i.e. vue-cli/packages/@vue/cli/lib/GeneratorAPI.js Lines 170 to 172 in 5efbd1b
Top level files work fine, because they start with underscore, vue-cli/packages/@vue/cli/lib/GeneratorAPI.js Line 175 in 5efbd1b
Should I test other globbing libs, to see if they return paths based on OS? Or we can safely assume that we can split by forward slash |
Thanks for diggign into this!
I think we should do that. Can you send a PR? |
Sure :) |
#2427 here you go. |
Version
3.0.1
Node and OS info
node v9.3.0 / npm 6.1.0 / Windows 10
Steps to reproduce
Start a new app with cli.
Select Cypress as e2e testing framework
What is expected?
installation finishes without errors
What is actually happening?
Lint rules are failing
https://gyazo.com/04e0ba22ffa2617e0d0e816623419ded
The _eslintrc.js file inside the templates folder of the cypress plugin is not being transformed to .eslintrc.js as per docs, so it just gets copied with the underscore in the name.
I can make a PR and rename it, but I am not sure that's the proper thing to do, as per the docs at least.
The text was updated successfully, but these errors were encountered: