fix(plugin api): fix generator dotfile rename for Windows. #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you rebase your commit and edit the message to include a reference to the original issue? https://github.com/vuejs/vue-cli/blob/dev/.github/COMMIT_CONVENTION.md Sidenote: the failing test is unrelated, I think Guillaume has to fix that. |
|
@LinusBorg want me to just rename the commit and force push my branch or? |
|
Exactly. |
dobromir-hristov
force-pushed
the
fix-generator-dotfile-rename-on-windows
branch
from
ef5b6d0 to
e711e0f
Compare
|
Should be alright now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with dotfile rename caused by Globby returning forward slashes instead of OS specific.