VDB-696: Remove recheck headers integration tests #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ar
approved these changes
Jun 18, 2019
elizabethengelman
force-pushed
the
VDB-696-remove-unused-repo-methods
branch
3 times, most recently
from
62c9c09 to
9ab313b
Compare
elizabethengelman
changed the base branch from
VDB-696-remove-unused-repo-methods
to
staging
yaoandrew
reviewed
Jun 19, 2019
| @@ -21,7 +21,6 @@ import ( | |||
| "github.com/ethereum/go-ethereum/ethclient" | |||
| . "github.com/onsi/ginkgo" | |||
| . "github.com/onsi/gomega" | |||
| "github.com/vulcanize/vulcanizedb/libraries/shared/constants" | |||
| "github.com/vulcanize/vulcanizedb/libraries/shared/fetcher" | |||
| "sort" | |||
There was a problem hiding this comment.
Hate to be that guy... import ordering 😅
There was a problem hiding this comment.
I always forget how we want to order things 🤦♀ , and Goland folds import statements up so I don't see them. I added a note in the CONTRIBUTING.md doc as a reminder for myself - does that sound about right?
yaoandrew
approved these changes
Jun 19, 2019
elizabethengelman
force-pushed
the
remove-recheck-headers-int-tests
branch
from
fb6a85c to
ce2dbec
Compare
since it's no longer a responsibility of this reop
elizabethengelman
force-pushed
the
remove-recheck-headers-int-tests
branch
from
840d008 to
61acc96
Compare
elizabethengelman
added a commit
that referenced
this pull request
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it's no longer a responsibility of this reop