Vdb 696 remove unused repo methods #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
changed the title
elizabethengelman
requested review from
m0ar,
rmulhol,
i-norden,
yaoandrew and
Gslaughl
and removed request for
m0ar
rmulhol
approved these changes
Jun 14, 2019
| @@ -90,10 +90,6 @@ func (repository JugInitRepository) MissingHeaders(startingBlockNumber, endingBl | |||
| return repo.MissingHeaders(startingBlockNumber, endingBlockNumber, repository.db, constants.JugInitChecked) | |||
There was a problem hiding this comment.
We should remove this too, right?
| @@ -93,10 +93,6 @@ func (repository VatForkRepository) MissingHeaders(startingBlockNumber, endingBl | |||
| return repo.MissingHeaders(startingBlockNumber, endingBlockNumber, repository.db, constants.VatForkChecked) | |||
| @@ -79,10 +79,6 @@ func (repository VatSuckRepository) MissingHeaders(startingBlock, endingBlock in | |||
| return repo.MissingHeaders(startingBlock, endingBlock, repository.db, constants.VatSuckChecked) | |||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| err = transformer.Execute(logs, header, constants.HeaderRecheck) | ||
| err = transformer.Execute(logs, header) |
There was a problem hiding this comment.
Wondering if we should remove the integration tests about rechecking headers, if that's not a responsibility of the event transformer anymore 🤔
There was a problem hiding this comment.
Yeah, that is a good point. I kind of want to think on that a bit more, so I may put up a separate PR for removing those tests.
| func (repository *MockRepository) SetMissingHeadersError(e error) { | ||
| repository.missingHeadersError = e | ||
| } | ||
|
|
||
| func (repository *MockRepository) SetAllHeaders(headers []core.Header) { |
There was a problem hiding this comment.
Can we delete this as well?
elizabethengelman
force-pushed
the
VDB-696-remove-unused-repo-methods
branch
from
8fa68e1 to
41313f0
Compare
|
removing rechecked headers int tests in #130 |
elizabethengelman
force-pushed
the
VDB-696-remove-unused-repo-methods
branch
from
41313f0 to
6cb0beb
Compare
Closed
elizabethengelman
force-pushed
the
VDB-696-remove-unused-repo-methods
branch
from
6cb0beb to
62c9c09
Compare
elizabethengelman
force-pushed
the
VDB-696-remove-unused-repo-methods
branch
from
62c9c09 to
9ab313b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging this in, I think it may be nice to merge in vulcanize/vulcanizedb#101 and then cut a new VDB release so we can target the release in the Gopkg instead of a version.