VDB-696 Update transformer execute #101
Conversation
elizabethengelman
force-pushed
the
update-transformer-execute
branch
from
d1c4d50 to
b169d70
Compare
| @@ -24,7 +24,6 @@ import ( | |||
| type Repository interface { | |||
| Create(headerID int64, models []interface{}) error | |||
| MarkHeaderChecked(headerID int64) error | |||
| MissingHeaders(startingBlockNumber, endingBlockNumber int64) ([]core.Header, error) | |||
| @@ -37,7 +36,7 @@ func (transformer Transformer) NewTransformer(db *postgres.DB) transformer.Event | |||
| return transformer | |||
| } | |||
|
|
|||
| func (transformer Transformer) Execute(logs []types.Log, header core.Header, recheckHeaders constants.TransformerExecution) error { | |||
| func (transformer Transformer) Execute(logs []types.Log, header core.Header) error { | |||
There was a problem hiding this comment.
This recheckHeaders argument is not being used in this Execute method.
elizabethengelman
force-pushed
the
update-transformer-execute
branch
from
b169d70 to
48afe39
Compare
elizabethengelman
force-pushed
the
update-transformer-execute
branch
from
48afe39 to
adf91df
Compare
| @@ -69,31 +69,6 @@ func MissingHeaders(startingBlockNumber, endingBlockNumber int64, db *postgres.D | |||
| return result, err | |||
| } | |||
|
|
|||
| func RecheckHeaders(startingBlockNumber, endingBlockNumber int64, db *postgres.DB, checkedHeadersColumn string) ([]core.Header, error) { | |||
There was a problem hiding this comment.
Looks like this method wasn't being called any longer.
Also, something else I hadn't realized previously was that in order to allow for rechecking headers, we need to pass in a CLI argument --recheck-headers when running composeAndExecute. 🌠
|
|
||
| var result bytes.Buffer | ||
|
|
||
| func CreateHeaderCheckedPredicateSQL(boolColumns []string, recheckHeaders constants.TransformerExecution) string { |
There was a problem hiding this comment.
I refactored this method into two smaller ones & changed the name as I was trying to understand how it was working. If folks don't find this refactoring helpful, I'm happy to undo it.
There was a problem hiding this comment.
I think it makes more sense this way 💯
elizabethengelman
changed the title
elizabethengelman
requested review from
rmulhol,
i-norden,
m0ar,
yaoandrew and
Gslaughl
and removed request for
rmulhol
| @@ -153,10 +149,11 @@ var _ = Describe("Repository", func() { | |||
| }) | |||
|
|
|||
| AfterEach(func() { | |||
| test_config.CleanCheckedHeadersTable(db, getExpectedColumnNames()) | |||
| //test_config.CleanCheckedHeadersTable(db, getExpectedColumnNames()) | |||
There was a problem hiding this comment.
Do we want to remove this AfterEach entirely?
There was a problem hiding this comment.
oh nice catch! i think I commented this out so I could get some data in my test db - I think it should still hang around.
| actual := shared.CreateNotCheckedSQL(columns, constants.HeaderMissing) | ||
| Expect(actual).To(Equal(expected)) | ||
| }) | ||
| Describe("CreateCustomColumnNamesSQL", func() { |
There was a problem hiding this comment.
Should this be "CreateHeaderCheckedPredicateSQL"?
| expected := fmt.Sprintf("NOT (columnA>=%s AND columnB>=%s)", constants.RecheckHeaderCap, constants.RecheckHeaderCap) | ||
| actual := shared.CreateNotCheckedSQL(columns, constants.HeaderRecheck) | ||
| Expect(actual).To(Equal(expected)) | ||
| Describe("RecheckHeadersCustomColumnNames", func() { |
There was a problem hiding this comment.
maybe rephrase to clarify how it's different from the above Describe
|
|
||
| var result bytes.Buffer | ||
|
|
||
| func CreateHeaderCheckedPredicateSQL(boolColumns []string, recheckHeaders constants.TransformerExecution) string { |
There was a problem hiding this comment.
I think it makes more sense this way 💯
No description provided.