Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR1432 alternative wording #1439

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Jul 8, 2020

@carmacleod

Thank you for #1432. Here is an idea for wording it to present the divergence as part of the accessibility features of the example. I'm not sure if I have the description of how mouse users cancel quite right.

Just an idea ... incorporate as you think best.

@carmacleod
Copy link
Contributor

carmacleod commented Jul 8, 2020

@mcking65
You are correct that mouse users can close and cancel by clicking back on the input.
Your new words are good. I'll merge them.
I was hoping someone would wordsmith the original - I just wanted to get it out there before the thoughts were gone. 😄
So, do I "squash & merge"? Or "rebase and merge"?

@mcking65 mcking65 merged commit ed2a9e1 into pr1396-accessibility-features Jul 8, 2020
@mcking65 mcking65 deleted the pr1432-option2 branch July 8, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants