Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select-only Combobox Example: Add Accessibility Features section #1432

Merged
merged 3 commits into from
Jul 14, 2020

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Jul 1, 2020

Ticks the checkbox in #1396 (comment) regarding mentioning the places where this diverges from html select behavior in an Accessibility Features section.

Preview in the compare branch for this PR

@carmacleod carmacleod requested review from smhigley and mcking65 July 1, 2020 14:20
@mcking65 mcking65 force-pushed the pr1396-accessibility-features branch from e710819 to 69c7588 Compare July 8, 2020 01:51
@mcking65
Copy link
Contributor

mcking65 commented Jul 8, 2020

Provided alternative wording to consider in #1439. Merge it here if you like.

@mcking65 mcking65 changed the title Add Accessibilty Features section to Select-only combobox example Select-only Combobox Example: Add Accessibility Features section Jul 8, 2020
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge. Will, however, wait for review from @smhigley

@mcking65 mcking65 merged commit f482257 into master Jul 14, 2020
@mcking65 mcking65 deleted the pr1396-accessibility-features branch July 14, 2020 17:45
michael-n-cooper pushed a commit that referenced this pull request Jul 14, 2020
Select-only Combobox Example: Add Accessibility Features section (pull #1432)

Co-authored-by: Matt King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants