-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2 spelling errors caught by CSpell during travis build #1448
Conversation
- controled -> controlled - enableing -> enabling
It looks like it did catch it https://github.com/w3c/aria-practices/pull/1413/checks |
Thanks, @nschonni - makes sense. |
The sub-job failed, but the overall build is marked as passed, since the spellcheck (and regressions) have the Line 31 in f482257
|
Thanks again @nschonni. I'll ask the others if they're comfortable failing builds for spelling errors. :) Forgive my inexperience with Travis here, but I'm not sure how to tell that the overall build was marked as passed? I see that the Test stage finished with 2 red X's out of 6 sub-jobs, and the fine print says those 2 are allowed to fail so Travis continued to the next stage. But the Deploy stage has red text and a red exclamation mark, and says "failed to deploy" in its log, so it seems that that stage failed? How can a build with a big red exclamation mark and red text with the word "errored" and a failed Deploy stage be interpreted as "passed"? I would've expected green text and a green checkmark and the word "passed", or at least yellow with an exclamation mark because the spellcheck and the regression test coverage failed. (Sorry to be such a noob... :) |
Thank you @carmacleod! |
Combobox Date Picker Example: Fix 2 spelling errors (pull #1448) - controled -> controlled - enableing -> enabling Co-authored-by: Matt King <[email protected]>
@carmacleod if you see the green checkmark next to the commit, then the overall job is passing or from the first paragraph of the I did find the fact that you can't currently do this with the GitHub Actions a little annoying when playing around with #1385 |
Aha! Thanks again @nschonni . I was looking at it from the build link that was sent to me in email (for some reason, build links started showing up in my email recently). I see that it's much clearer if you go to the PR and look at the build info from that angle. :) |
This little PR was created without a fork. Just making sure everything works ok. :)
This fixes the failing build for PR #1432 Select-only Combobox Example: Add Accessibility Features section.
Not sure why CSpell didn't catch these before PR #1413 was merged? Almost looks like Travis didn't run CSpell that day?