[css-color-adjust] Define color-scheme: normal to be hookable by HTML. #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
added a commit
to emilio/html
that referenced
this pull request
Oct 15, 2021
Depends on w3c/csswg-drafts#6731 Fixes whatwg#7213.
This was referenced Oct 15, 2021
lilles
reviewed
Oct 15, 2021
lilles
reviewed
Oct 15, 2021
tabatkins
reviewed
Oct 15, 2021
|
GitHub's commenting/suggestion UI is failing me (I can't start a fresh comment on a line if there's already one there, and the set of lines being commented on is set by the initial one so I can't drop a suggestion for an entire paragraph...), but this patch breaks the semantic linebreaking the spec uses. Reformatting to that would be nice, so Elika or I don't have to do that later in a separate commit. ^_^ |
This allows HTML to "set" the used value of the color-scheme property, via a meta tag. Part of whatwg/html#7213 Closes w3c#6726
emilio
force-pushed
the
color-scheme-normal
branch
from
80a9661 to
aee8efe
Compare
tabatkins
approved these changes
Oct 15, 2021
|
👍, merge when you're ready |
emilio
added a commit
to emilio/html
that referenced
this pull request
Oct 15, 2021
Depends on w3c/csswg-drafts#6731 Fixes whatwg#7213.
emilio
added a commit
to emilio/html
that referenced
this pull request
Oct 16, 2021
Depends on w3c/csswg-drafts#6731 Fixes whatwg#7213.
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 18, 2021
Closes #7213. See also w3c/csswg-drafts#6731.
dandclark
pushed a commit
to dandclark/html
that referenced
this pull request
Dec 4, 2021
Closes whatwg#7213. See also w3c/csswg-drafts#6731.
5 tasks
|
The CSS Working Group just discussed The full IRC log of that discussion<fantasai> Topic: CSS Color Adjust L1<fantasai> fantasai: don't remember why this is on agenda <fantasai> fantasai: Snapshot us updated, and I think we have a resolution in place? <fantasai> chris: There was a new issue, significant change, do we need a separate resolution? <fantasai> change -> <fantasai> https://github.com//pull/6731/files <florian_irc> fantasai: we need a resolution to accept the change <fantasai> github: https://github.com//pull/6731 <fantasai> Rossen_: Ok, since Tab and emilio aren't around, let's review this next week |
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Jun 3, 2022
Closes whatwg#7213. See also w3c/csswg-drafts#6731.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows HTML to "set" the used value of the color-scheme property,
via a meta tag.
Part of whatwg/html#7213
Closes #6726