Tweak <meta name=color-scheme> definition. #7226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
added a commit
to emilio/web-platform-tests
that referenced
this pull request
Oct 15, 2021
This makes the assumption that the initial browser's color-scheme is light, which I think is a reasonable assumption to run these tests under. An alternative would have to allow both "light" and "dark" wherever we check for "normal" now (which loses test coverage in practice), or I could complicate the test to compute the initial color-scheme using an iframe or what not (but that complicates everything more).
emilio
added a commit
to emilio/web-platform-tests
that referenced
this pull request
Oct 15, 2021
…lor-scheme computed value (before whatwg/html#7226) This makes the tests valid both with and without the spec change proposed above. Will send a follow-up PR to test the spec change. This makes the assumption that the initial browser's color-scheme is light, which I think is a reasonable assumption to run these tests under. An alternative would have to allow both "light" and "dark" wherever we check for "normal" now (which loses test coverage in practice), or I could complicate the test to compute the initial color-scheme using an iframe or what not (but that complicates everything more).
emilio
added a commit
to emilio/web-platform-tests
that referenced
this pull request
Oct 15, 2021
This tests the spec change in whatwg/html#7226.
emilio
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 15, 2021
…lor-scheme computed value (before whatwg/html#7226) This makes the tests valid both with and without the spec change proposed above. Will send a follow-up PR to test the spec change. This makes the assumption that the initial browser's color-scheme is light, which I think is a reasonable assumption to run these tests under. An alternative would have to allow both "light" and "dark" wherever we check for "normal" now (which loses test coverage in practice), or I could complicate the test to compute the initial color-scheme using an iframe or what not (but that complicates everything more).
emilio
added a commit
to emilio/web-platform-tests
that referenced
this pull request
Oct 15, 2021
This tests the spec change in whatwg/html#7226.
tabatkins
reviewed
Oct 15, 2021
domenic
reviewed
Oct 15, 2021
emilio
added a commit
to emilio/web-platform-tests
that referenced
this pull request
Oct 15, 2021
This tests the spec change in whatwg/html#7226.
domenic
approved these changes
Oct 15, 2021
Depends on w3c/csswg-drafts#6731 Fixes whatwg#7213.
Done then :) |
|
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=1260617 for Chrome (referenced in the PR description too) |
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 25, 2021
This tests the spec change in whatwg/html#7226.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 29, 2021
…heme> to not depend on the color-scheme computed value (before whatwg/html#7226), a=testonly Automatic update from web-platform-tests Change wpt tests for <meta name=color-scheme> to not depend on the color-scheme computed value (before whatwg/html#7226) This makes the tests valid both with and without the spec change proposed above. Will send a follow-up PR to test the spec change. This makes the assumption that the initial browser's color-scheme is light, which I think is a reasonable assumption to run these tests under. An alternative would have to allow both "light" and "dark" wherever we check for "normal" now (which loses test coverage in practice), or I could complicate the test to compute the initial color-scheme using an iframe or what not (but that complicates everything more). -- wpt-commits: 705c808e7a972bc3454f1842cd73f1e85ee31818 wpt-pr: 31268
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 29, 2021
…t create a pres hint., a=testonly Automatic update from web-platform-tests Assert that color-scheme meta tag doesn't create a pres hint This tests the spec change in whatwg/html#7226. -- wpt-commits: 13a5f1e14ff1ad575a46d03ea73c4f019f6e6036 wpt-pr: 31271
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 1, 2021
…heme> to not depend on the color-scheme computed value (before whatwg/html#7226), a=testonly Automatic update from web-platform-tests Change wpt tests for <meta name=color-scheme> to not depend on the color-scheme computed value (before whatwg/html#7226) This makes the tests valid both with and without the spec change proposed above. Will send a follow-up PR to test the spec change. This makes the assumption that the initial browser's color-scheme is light, which I think is a reasonable assumption to run these tests under. An alternative would have to allow both "light" and "dark" wherever we check for "normal" now (which loses test coverage in practice), or I could complicate the test to compute the initial color-scheme using an iframe or what not (but that complicates everything more). -- wpt-commits: 705c808e7a972bc3454f1842cd73f1e85ee31818 wpt-pr: 31268
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 1, 2021
…t create a pres hint., a=testonly Automatic update from web-platform-tests Assert that color-scheme meta tag doesn't create a pres hint This tests the spec change in whatwg/html#7226. -- wpt-commits: 13a5f1e14ff1ad575a46d03ea73c4f019f6e6036 wpt-pr: 31271
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
…lor-scheme computed value (before whatwg/html#7226) This makes the tests valid both with and without the spec change proposed above. Will send a follow-up PR to test the spec change. This makes the assumption that the initial browser's color-scheme is light, which I think is a reasonable assumption to run these tests under. An alternative would have to allow both "light" and "dark" wherever we check for "normal" now (which loses test coverage in practice), or I could complicate the test to compute the initial color-scheme using an iframe or what not (but that complicates everything more).
Gabisampaio
pushed a commit
to Gabisampaio/wpt
that referenced
this pull request
Nov 18, 2021
This tests the spec change in whatwg/html#7226.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on w3c/csswg-drafts#6731
Fixes #7213.
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/semantics.html ( diff )