Rename DUBBING_ORIGINAL_DIALOGUE_LIST and DUBBING_TRANSLATED_DIALOGUE_LIST #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LIST Closes #87. * Change `DUBBING_ORIGINAL_DIALOGUE_LIST` to `ORIGINAL_TRANSCRIPT` and change the name "Original Language Dialogue List" to "Original Language Transcript" * Change `DUBBING_TRANSLATED_DIALOGUE_LIST` to `TRANSLATED_TRANSCRIPT` and change the name "Translated Dialogue List" to "Translated Transcript" * Split out the list of script types that are Dubbing Scripts into a separate paragraph for readability. * Propagate changes throughout the examples * Add an Ed Note before Example 12 - looks like it's orphaned and needs to move higher up, possibly.
cconcolato
reviewed
Dec 21, 2022
I'd rather not - see also #101 where I try to make the distinction clearer and more useful. |
|
This will have conflicts with #101 but is broadly aligned with the direction of change in that pull request too. |
Merged
|
I've merged this into #101, so closing this. Makes sense to review them together in the context of improving the consistency of how the spec uses the terminology "script" and "transcript". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87.
DUBBING_ORIGINAL_DIALOGUE_LISTtoORIGINAL_TRANSCRIPTand change the name "Original Language Dialogue List" to "Original Language Transcript"DUBBING_TRANSLATED_DIALOGUE_LISTtoTRANSLATED_TRANSCRIPTand change the name "Translated Dialogue List" to "Translated Transcript"Preview | Diff