Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DUBBING_ORIGINAL_DIALOGUE_LIST and DUBBING_TRANSLATED_DIALOGUE_LIST #87

Closed
nigelmegitt opened this issue Dec 6, 2022 · 0 comments · Fixed by #101
Closed

Rename DUBBING_ORIGINAL_DIALOGUE_LIST and DUBBING_TRANSLATED_DIALOGUE_LIST #87

nigelmegitt opened this issue Dec 6, 2022 · 0 comments · Fixed by #101
Assignees
@nigelmegitt

Comments

@nigelmegitt
Copy link
Contributor

Looking at the values of Script Type, the suffix _LIST looks out of place in the two in which it occurs.

   Looking at these values, the suffix `_LIST` looks out of place. And since we're now being explicit about it possibly containing on screen text as well as dialogue, the `DIALOGUE` bit looks odd too. Happy to open as a separate issue, but I'm leaning towards just `ORIGINAL_TRANSCRIPT` and `TRANSLATED_TRANSCRIPT`, partly because I think they are clearer and also because I suspect they are likely to be more generally useful beyond just dubbing workflows.

I'd keep DUBBING_PRE_RECORDED and DUBBING_AS_RECORDED as they are.

Originally posted by @nigelmegitt in #85 (comment)
@nigelmegitt nigelmegitt self-assigned this Dec 15, 2022
nigelmegitt added a commit that referenced this issue Dec 16, 2022
@nigelmegitt
Rename DUBBING_ORIGINAL_DIALOGUE_LIST and DUBBING_TRANSLATED_DIALOGUE…
e8e771c 
…_LIST

Closes #87.

* Change `DUBBING_ORIGINAL_DIALOGUE_LIST` to `ORIGINAL_TRANSCRIPT` and change the name "Original Language Dialogue List" to "Original Language Transcript"
* Change `DUBBING_TRANSLATED_DIALOGUE_LIST` to `TRANSLATED_TRANSCRIPT` and change the name "Translated Dialogue List" to "Translated Transcript"
* Split out the list of script types that are Dubbing Scripts into a separate paragraph for readability.
* Propagate changes throughout the examples
* Add an Ed Note before Example 12 - looks like it's orphaned and needs to move higher up, possibly.
This was referenced Dec 16, 2022
Closed
Merged
nigelmegitt added a commit that referenced this issue Jan 19, 2023
@nigelmegitt
Rename DUBBING_ORIGINAL_DIALOGUE_LIST and DUBBING_TRANSLATED_DIALOGUE…
0be43ee 
…_LIST

Closes #87.

* Change `DUBBING_ORIGINAL_DIALOGUE_LIST` to `ORIGINAL_TRANSCRIPT` and change the name "Original Language Dialogue List" to "Original Language Transcript"
* Change `DUBBING_TRANSLATED_DIALOGUE_LIST` to `TRANSLATED_TRANSCRIPT` and change the name "Translated Dialogue List" to "Translated Transcript"
* Split out the list of script types that are Dubbing Scripts into a separate paragraph for readability.
* Propagate changes throughout the examples
* Add an Ed Note before Example 12 - looks like it's orphaned and needs to move higher up, possibly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nigelmegitt nigelmegitt

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nigelmegitt