replace ttm:role by daptm:scriptType #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelmegitt
approved these changes
Dec 6, 2022
Comment on lines
+353
to
+354
| : "DUBBING_ORIGINAL_DIALOGUE_LIST" | ||
| | "DUBBING_TRANSLATED_DIALOGUE_LIST" |
There was a problem hiding this comment.
Looking at these values, the suffix _LIST looks out of place. And since we're now being explicit about it possibly containing on screen text as well as dialogue, the DIALOGUE bit looks odd too. Happy to open as a separate issue, but I'm leaning towards just ORIGINAL_TRANSCRIPT and TRANSLATED_TRANSCRIPT, partly because I think they are clearer and also because I suspect they are likely to be more generally useful beyond just dubbing workflows.
I'd keep DUBBING_PRE_RECORDED and DUBBING_AS_RECORDED as they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #24
close #32
close #33
close #54
Preview | Diff