-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accurately describe dependence on registries #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but noting that this whole section is likely to disappear after the intro sections rewrite that is coming up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just two suggestions regarding the use of the words "member" and "identifier".
Co-authored-by: Markus Sabadello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial, multiple positive reviews, changes made, merging.
and cryptographic algorithm identifiers. | ||
Some of these registries are operated by the W3C DID Working group | ||
and others are operated by other standards organizations, including the IETF. | ||
</p> | ||
|
||
<p> | ||
This design eliminates dependence on centralized registries | ||
for key management, which is the | ||
for identifier and key management, which is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding "identifier and" is incorrect here because we are relying on working group registries for managing identifiers, including property names, algorithms names, and parameter names. Please delete "identifier and". I'm fine with the rest of the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "identifier" part of this is referring to the identifiers used in the Verifiable Data Registry (e.g., the DLT network) .... not the identifiers used in the "DID Specification Registries". I believe the change @peacekeeper suggested is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As worded, it doesn't say that. It makes it sound like registries aren't used for any identifiers, which is clearly false.
Please change the "identifier and" added to something more specific such as "identifier in the Verifiable Data Registry and" so that it's not misleading or simply delete it, as the PR did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the word "registry" in 200cff0. It now reads:
This design eliminates dependence on centralized identifier and key management systems, which is the standard in hierarchical PKI (public key infrastructure).
Is that better?
Also note that this section is in the process of getting heavily rewritten, so I expect large swaths of text to not survive the next week... just as a heads-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The working group decided to take a dependency on centralized registries. We should own that and not try to imply that we didn't. The current text is still misleading. How about this proposed wording?
This design eliminates dependence on centralized identifier and key management systems, other than the registries established by and used by this specification. Note that centralized identifier and key management is used by existing hierarchical PKI (public key infrastructure) systems.
Fixes #160
Preview | Diff