Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurately describe dependence on registries #277

Merged
merged 2 commits into from
May 16, 2020
Merged

Accurately describe dependence on registries #277

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6810b7
Accurately describe dependence on registries
selfissued May 12, 2020
700f4e3
Apply suggestions from @peacekeeper.
msporny May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,17 +280,16 @@ <h1>

<p>
This specification utilizes registries to enable interoperable definitions of
identifiers used by DID implementations, including
<a>DID document</a> member names defined by this and other specifications,
<a>DID methods</a>,
<a>DID document</a> property names defined by this and other specifications,
<a>DID method</a> names, DID parameter names,
and cryptographic algorithm identifiers.
Some of these registries are operated by the W3C DID Working group
and others are operated by other standards organizations, including the IETF.
</p>

<p>
This design eliminates dependence on centralized registries
for key management, which is the
for identifier and key management, which is the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding "identifier and" is incorrect here because we are relying on working group registries for managing identifiers, including property names, algorithms names, and parameter names. Please delete "identifier and". I'm fine with the rest of the changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "identifier" part of this is referring to the identifiers used in the Verifiable Data Registry (e.g., the DLT network) .... not the identifiers used in the "DID Specification Registries". I believe the change @peacekeeper suggested is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As worded, it doesn't say that. It makes it sound like registries aren't used for any identifiers, which is clearly false.

Please change the "identifier and" added to something more specific such as "identifier in the Verifiable Data Registry and" so that it's not misleading or simply delete it, as the PR did.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the word "registry" in 200cff0. It now reads:

This design eliminates dependence on centralized identifier and key management systems, which is the standard in hierarchical PKI (public key infrastructure).

Is that better?

Also note that this section is in the process of getting heavily rewritten, so I expect large swaths of text to not survive the next week... just as a heads-up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The working group decided to take a dependency on centralized registries. We should own that and not try to imply that we didn't. The current text is still misleading. How about this proposed wording?

This design eliminates dependence on centralized identifier and key management systems, other than the registries established by and used by this specification. Note that centralized identifier and key management is used by existing hierarchical PKI (public key infrastructure) systems.

standard in hierarchical <a
href="https://en.wikipedia.org/wiki/Public_key_infrastructure">
PKI (public key infrastructure</a>).
Expand Down