Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate Recommendation #59

Merged
merged 17 commits into from
Jun 19, 2023
Merged

Candidate Recommendation #59

merged 17 commits into from
Jun 19, 2023

Conversation

palemieux
Copy link
Contributor

@palemieux palemieux commented Dec 14, 2022

Add exit criteria
Add at-risk features
Add substantive changes summary
spec/imsc-hrm.html Outdated Show resolved Hide resolved
spec/imsc-hrm.html Outdated Show resolved Hide resolved
spec/imsc-hrm.html Outdated Show resolved Hide resolved
spec/imsc-hrm.html Outdated Show resolved Hide resolved
spec/substantive-changes-summary.txt Outdated Show resolved Hide resolved
@palemieux palemieux mentioned this pull request Dec 16, 2022
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like structuring the Summary of substantive changes section this way.

spec/imsc-hrm.html Outdated Show resolved Hide resolved
spec/imsc-hrm.html Outdated Show resolved Hide resolved
@css-meeting-bot
Copy link
Member

The Timed Text Working Group just discussed CR1 Exit Criteria, and agreed to the following:

  • SUMMARY: Proceed as-is
The full IRC log of that discussion <nigel> Subtopic: CR1 Exit Criteria
<nigel> github: https://github.com//pull/59
<nigel> Nigel: Is this still a draft PR?
<nigel> Pierre: Yes, to prevent merging, as much as anything else.
<nigel> .. The outstanding thing is how to label at-risk features.
<nigel> .. I'm not happy with it.
<nigel> .. I think we should go back to a simple statement rather than linking to issues.
<nigel> .. It's confusing, and doesn't bring us anything because we don't have many features at risk.
<nigel> q+
<nigel> .. I propose to remove those links.
<nigel> ack nb
<nigel> ack n
<nigel> Nigel: I'm not sure what the problem is - I'm actually quite happy with it as it stands.
<nigel> Pierre: OK, what about you Atsushi?
<nigel> Atsushi: I don't have objections
<nigel> Pierre: Okay, maybe we should resolve those threads and call it done.
<nigel> SUMMARY: Proceed as-is

@palemieux palemieux marked this pull request as ready for review April 13, 2023 15:31
@palemieux palemieux closed this Apr 13, 2023
@palemieux palemieux reopened this Apr 13, 2023
Comment on lines 202 to 207
<p>For this specification to exit the CR stage, at least 1 of each, and at least 2 of one, of the following
independent factors of verifications SHALL be demonstrated:</p>
<ul>
<li>content producing implementation</li>
<li>validating implementation</li>
</ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In view of the algorithm specified by the specification, if there were two validating implementations and no content producing implementations, I think that should be adequate to exit CR. I don't believe it is symmetrical the other way though: 2 content producing implementations would not be adequate.

Suggested change
<p>For this specification to exit the CR stage, at least 1 of each, and at least 2 of one, of the following
independent factors of verifications SHALL be demonstrated:</p>
<ul>
<li>content producing implementation</li>
<li>validating implementation</li>
</ul>
<p>For this specification to exit the CR stage, one of the following minimum
combinations of independent factors of verifications SHALL be demonstrated:</p>
<ul>
<li>at least 1 content producing implementation and at least 1 validating implementation OR</li>
<li>at least 2 independent validating implementations</li>
</ul>

//, processVersion: "2018"
//, previousMaturity: "PR"
//, publishDate: "2021-11-09"
//, modificationDate: "2020-04-27"
//, errata: ""
//, implementationReportURI: ""
, crEnd: "2023-03-01"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this date will need to change, suggest publication date + 8 weeks (4 is the process-defined minimum, I believe).

@@ -242,6 +254,7 @@ <h2>Terms and Definitions</h2>
<p>
Unless noted otherwise, this specification applies to an <a>IMSC Document Instance</a>.
</p>
<div class="issue" data-number="63"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think citing this issue in the Conformance section is particularly helpful - I'd remove it from this one location.

@palemieux palemieux requested a review from nigelmegitt April 27, 2023 15:08
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I will issue a CfC for publication of CR.

@himorin
Copy link
Contributor

himorin commented May 23, 2023

+1 to go.

Just for memo, and I'm not sure whether we will get comment or not, but we may be asked about what kind of verification to be performed by implementation? (e.g. difference from one verification implementation over two sets of data from independent implementations, which we said during discussion)

@himorin
Copy link
Contributor

himorin commented Jun 19, 2023

@palemieux @nigelmegitt could you merge this PR?

  • target publication date: 2023-06-22
  • minimum crEnd (28days): 2023-07-20

@palemieux palemieux merged commit 2149d72 into main Jun 19, 2023
@palemieux
Copy link
Contributor Author

@himorin Merged and tagged

@himorin
Copy link
Contributor

himorin commented Jun 19, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants