Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the [NoInterfaceObject] for SVGPathSegment #802

Closed
wants to merge 2 commits into from
Closed

Drop the [NoInterfaceObject] for SVGPathSegment #802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da2321d
Drop the [NoInterfaceObject] for SVGPathSegment
foolip Jul 1, 2020
bbeb890
Fix more Web IDL errors
foolip Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions specs/paths/master/Overview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,10 +1368,10 @@ <h3 id="InterfaceSVGPathSegment">Interface SVGPathSegment</h3>
The <a>SVGPathSegment</a> interface is a base interface that corresponds to a
single command within a path data specification.

<pre class="idl">[NoInterfaceObject]
<pre class="idl">
interface <b>SVGPathSegment</b> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at how this is used, maybe this can even be a dictionary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right, that would be fine in this case, and would avoid the need to make values a FrozenArray<float> as one would need to do to keep this an interface.

DOMString type;
sequence&lt;float> values;
attribute DOMString type;
attribute FrozenArray&lt;float> values;
};</pre>

<dl class="interface">
Expand All @@ -1397,7 +1397,7 @@ <h3 id="InterfaceSVGPathData" data-dfn-type="interface" data-lt="SVGPathData">Mi
<pre class="idl">
dictionary <b id="InterfaceSVGPathDataSettings">SVGPathDataSettings</b> {
boolean normalize = false;
}
};

interface mixin <b>SVGPathData</b> {
sequence&lt;<a>SVGPathSegment</a>> getPathData(optional <a>SVGPathDataSettings</a> settings);
Expand Down