Drop the [NoInterfaceObject] for SVGPathSegment #802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been renamed in Web IDL: https://heycam.github.io/webidl/#LegacyNoInterfaceObject However, if the interface is implemented, it would be best to expose it for feature detection.
foolip
added a commit
to foolip/webref
that referenced
this pull request
Jul 3, 2020
foolip
added a commit
to foolip/webref
that referenced
this pull request
Jul 3, 2020
|
@tabatkins do you know who I can poke for review of a change like this? |
foolip
added a commit
to foolip/webref
that referenced
this pull request
Jul 13, 2020
foolip
added a commit
to foolip/webref
that referenced
this pull request
Jul 22, 2020
saschanaz
reviewed
Oct 25, 2020
| @@ -1368,10 +1368,10 @@ <h3 id="InterfaceSVGPathSegment">Interface SVGPathSegment</h3> | |||
| The <a>SVGPathSegment</a> interface is a base interface that corresponds to a | |||
| single command within a path data specification. | |||
|
|
|||
| <pre class="idl">[NoInterfaceObject] | |||
| <pre class="idl"> | |||
| interface <b>SVGPathSegment</b> { | |||
There was a problem hiding this comment.
Looking at how this is used, maybe this can even be a dictionary.
There was a problem hiding this comment.
I think you're right, that would be fine in this case, and would avoid the need to make values a FrozenArray<float> as one would need to do to keep this an interface.
queengooborg
pushed a commit
to foolip/webref
that referenced
this pull request
Nov 18, 2020
queengooborg
pushed a commit
to foolip/webref
that referenced
this pull request
Dec 14, 2020
|
SVGPathElement is now defined by SVG 2, maybe this spec should be dropped. Edit: Per MDN the segment part has been dropped in SVG 2. |
foolip
added a commit
to foolip/webref
that referenced
this pull request
Jan 21, 2021
foolip
added a commit
to foolip/webref
that referenced
this pull request
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been renamed in Web IDL:
https://heycam.github.io/webidl/#LegacyNoInterfaceObject
However, if the interface is implemented, it would be best to expose it for feature detection.