LockGrantedCallback IDL looks wrong #51
Comments
|
Whoops, yep. Fixed. WPT change coming. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Oct 22, 2018
A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Oct 22, 2018
A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <[email protected]> Commit-Queue: Victor Costan <[email protected]> Reviewed-by: Victor Costan <[email protected]> Cr-Commit-Position: refs/heads/master@{#601716}
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Oct 22, 2018
A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <[email protected]> Commit-Queue: Victor Costan <[email protected]> Reviewed-by: Victor Costan <[email protected]> Cr-Commit-Position: refs/heads/master@{#601716}
servo-wpt-sync
pushed a commit
to servo-wpt-sync/web-platform-tests
that referenced
this issue
Oct 22, 2018
A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <[email protected]> Commit-Queue: Victor Costan <[email protected]> Reviewed-by: Victor Costan <[email protected]> Cr-Commit-Position: refs/heads/master@{#601716}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Nov 7, 2018
Automatic update from web-platform-testsWeb Locks API: Fix IDL glitch A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <[email protected]> Commit-Queue: Victor Costan <[email protected]> Reviewed-by: Victor Costan <[email protected]> Cr-Commit-Position: refs/heads/master@{#601716} -- wpt-commits: 5a889be7d8cb12db57ab8bf32d2640e948ba1b2d wpt-pr: 13665
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this issue
Nov 8, 2018
Automatic update from web-platform-testsWeb Locks API: Fix IDL glitch A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <[email protected]> Commit-Queue: Victor Costan <[email protected]> Reviewed-by: Victor Costan <[email protected]> Cr-Commit-Position: refs/heads/master@{#601716} -- wpt-commits: 5a889be7d8cb12db57ab8bf32d2640e948ba1b2d wpt-pr: 13665
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 3, 2019
Automatic update from web-platform-testsWeb Locks API: Fix IDL glitch A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <jsbellchromium.org> Commit-Queue: Victor Costan <pwnallchromium.org> Reviewed-by: Victor Costan <pwnallchromium.org> Cr-Commit-Position: refs/heads/master{#601716} -- wpt-commits: 5a889be7d8cb12db57ab8bf32d2640e948ba1b2d wpt-pr: 13665 UltraBlame original commit: cc019e5de38364c90a28f8a3fb7c3820ed9de1f2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 3, 2019
Automatic update from web-platform-testsWeb Locks API: Fix IDL glitch A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <jsbellchromium.org> Commit-Queue: Victor Costan <pwnallchromium.org> Reviewed-by: Victor Costan <pwnallchromium.org> Cr-Commit-Position: refs/heads/master{#601716} -- wpt-commits: 5a889be7d8cb12db57ab8bf32d2640e948ba1b2d wpt-pr: 13665 UltraBlame original commit: cc019e5de38364c90a28f8a3fb7c3820ed9de1f2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 3, 2019
Automatic update from web-platform-testsWeb Locks API: Fix IDL glitch A callback defined in Web IDL should take a nullable argument. We don't enforce this in our bindings code and it can't be introspected from JS so this is not a testable or web-facing change, just aligning the code with a spec fix. Spec issue: w3c/web-locks#51 Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4 Reviewed-on: https://chromium-review.googlesource.com/c/1294421 Commit-Queue: Joshua Bell <jsbellchromium.org> Commit-Queue: Victor Costan <pwnallchromium.org> Reviewed-by: Victor Costan <pwnallchromium.org> Cr-Commit-Position: refs/heads/master{#601716} -- wpt-commits: 5a889be7d8cb12db57ab8bf32d2640e948ba1b2d wpt-pr: 13665 UltraBlame original commit: cc019e5de38364c90a28f8a3fb7c3820ed9de1f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The IDL says:
but https://wicg.github.io/web-locks/#algorithm-request-lock step 6.1.1 passes
nullas the argument, which is not a validLockvalue. Presumably this callback should takeLock?.The text was updated successfully, but these errors were encountered: