Skip to content

Commit

Permalink
Web Locks API: Fix IDL glitch
Browse files Browse the repository at this point in the history
A callback defined in Web IDL should take a nullable argument. We
don't enforce this in our bindings code and it can't be introspected
from JS so this is not a testable or web-facing change, just aligning
the code with a spec fix.

Spec issue: w3c/web-locks#51
Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback

Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4
  • Loading branch information
inexorabletash authored and chromium-wpt-export-bot committed Oct 22, 2018
1 parent 548a7a4 commit 532fe9e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion web-locks/web-locks.idl
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ interface LockManager {
Promise<LockManagerSnapshot> query();
};

callback LockGrantedCallback = Promise<any> (Lock lock);
callback LockGrantedCallback = Promise<any> (Lock? lock);

enum LockMode { "shared", "exclusive" };

Expand Down

0 comments on commit 532fe9e

Please sign in to comment.