Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated quote style #1141

Closed
cheywood opened this issue Mar 22, 2021 · 4 comments · Fixed by #1165
Closed

Updated quote style #1141

cheywood opened this issue Mar 22, 2021 · 4 comments · Fixed by #1165
Labels
Improvement UI
Milestone
2.4.3

Comments

@cheywood
Copy link
Contributor

cheywood commented Mar 22, 2021 •
edited
Loading

Hi, I have some draft changes to the quote style making them closer to the style on the Wallabag web service.

eg. From ...

image

To ...

image

Is that of interest? I can send through a PR. pre blocks are unchanged.
@di72nn
Copy link
Member

di72nn commented Mar 29, 2021

Hi, thanks!

I, for one, like the suggested change.
@ngosang you did a quotes-related PR, what do you think?

@cheywood
Copy link
Contributor Author

I should have mentioned that I'm suggesting the change as it wasn't immediately obvious to me what the quote blocks were. Aligning up with Wallabag web's perhaps more conventional style seemed like a reasonable approach 🙂

@ngosang
Copy link
Contributor

ngosang commented Mar 29, 2021

I think it's a good idea. Please, open the PR. Just remember to test all the themes. Thank you!

cheywood pushed a commit to cheywood/android-app that referenced this issue Mar 30, 2021
Updated quote style
76ad9a6 
More inline with web service. Closes wallabag#1141.
@cheywood cheywood mentioned this issue Mar 30, 2021
Closed
@cheywood
Copy link
Contributor Author

Great, thanks, PR created. Only tested on the single device thus far.

@cheywood cheywood mentioned this issue May 16, 2021
Merged
@di72nn di72nn added this to the 2.4.3 milestone Jun 17, 2021
@di72nn di72nn mentioned this issue Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement UI
Projects
None yet
Milestone
2.4.3
3 participants
@di72nn @ngosang @cheywood