Update quote style and remove bottom margin from paragraphs within them #1165
Conversation
|
Thanks! I haven't tested it, but I believe it will also remove margins between multiple paragraphs in a quote. Have you checked that? |
|
I was wondering about that too (... and to be honest I think it then slipped my mind 🤦 ). They also don't often occur in my feeds. Do you happen to have a feed/article I could test this with? |
|
I've just put up a fix, but have thus far only tested it with single paragraph quotes (which it works for) |
|
Multiple I haven't tested these with this PR. |
|
Hrmm yeah the rest look ok but the towards data science article shows another problem which would be exacerbated if these PRs are merged. It looks like sometimes there's no spacing left after the |
This is similar to what wallabag web is doing and avoids cases where two blockquotes would be joined without space, or a blockquote could end up butted up against the following content.
|
I've had a go at that too. Blockquotes will be spaced out a little more, closer to wallabag web, which looks fine to me but may be subjective. |
|
Thanks for your efforts! The changes seem to cover most of the problems, except for However, I feel like the web UI does it somehow differently and trying to borrow that approach is a better way to go. |
|
I agree, having more coverage ala the wallabag web stylesheet would avoid these issues, with the benefit of (arguably) improved style (including eg. the improved quote style that kicked this off). I think effectively tracking the web stylesheet is a good idea. I can remove these PRs if you'd like. |
No, I don't think anything major is going to happen to styles in the app (at least anytime soon), so these PRs still make sense. But for this fix we should try collapsing bottom margins (like in the web UI, if I understand correctly) instead of removing margins from |
Brings in changes for wallabag#1143, removing all borders and padding between blockquote and children, allowing for margin collapsing
|
Sure thing. Have made changes to allow for margin collapsing. As a result integrated #1143 changes as that helps in removing the border between the parent FYI won't be back in internet reception for half a week or so. |
|
By the way, sorry for the rushed approach to my changes on the margin issue, FWIW that's not normally my way |
Don't worry, it's ok :-) Looks nice, thanks again! Can you please double-check the |
|
Oh, and about the |
cheywood
changed the title
Nice, looks good, done. |
Yeah, I think I'd excluded it from solarized as it wasn't used, and for dark who knows why I didn't. The more contrast the better, right? 🙂 Updated. |
|
Everything looks good, thanks again! |
@di72nn as you identified this was to do with padding on the bottom of paragraphs within the blockquote. Looks good for me for articles which were and weren't affected by the issue.
Fixes #1163
Closes #1141