Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes have some excessive space at the bottom #1163

Closed
di72nn opened this issue May 11, 2021 · 0 comments · Fixed by #1165
Closed

Quotes have some excessive space at the bottom #1163

di72nn opened this issue May 11, 2021 · 0 comments · Fixed by #1165
Labels

Comments

@di72nn
Copy link
Member

di72nn commented May 11, 2021

Discussed in #1143.

quote

cheywood pushed a commit to cheywood/android-app that referenced this issue May 12, 2021
cheywood pushed a commit to cheywood/android-app that referenced this issue May 12, 2021
Strubbl pushed a commit that referenced this issue Jun 14, 2021
…em (#1165)

* Remove bottom margin from paragraphs in quote blocks

Fixes #1163

* Ensure that spaces between paragraphs in quotes will remain

#1163

* Ensure sufficient spacing above and below blockquotes

This is similar to what wallabag web is doing and avoids cases where
two blockquotes would be joined without space, or a blockquote could end
up butted up against the following content.

* Further fixes for blockquote extra bottom margin

Brings in changes for #1143, removing all borders and padding between
blockquote and children, allowing for margin collapsing

* Whitespace fix

* Quote accent colour change as requested

* Sync quote high contrast change across themes

Co-authored-by: Chris Heywood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant