Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): Add corresponding string op to FE to parse number with thousands and decimal separators #2959

Merged
merged 3 commits into from
Nov 15, 2024
Merged

feat(app): Add corresponding string op to FE to parse number with thousands and decimal separators #2959

merged 3 commits into from
Nov 15, 2024

Conversation

nicholaspun-wandb
Copy link
Contributor

@nicholaspun-wandb nicholaspun-wandb commented Nov 12, 2024 •
edited by jira bot
Loading

Description

Testing

  • Unit tests
  • Manually with local FE
Screenshot 2024-11-12 at 3 28 47 PM

@nicholaspun-wandb nicholaspun-wandb self-assigned this Nov 12, 2024
@nicholaspun-wandb nicholaspun-wandb requested a review from a team as a code owner November 12, 2024 23:35
@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 12, 2024 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=b7ca39251c04d6ffcd9244132b5fe9d4e125e42e

@nicholaspun-wandb nicholaspun-wandb enabled auto-merge (squash) November 14, 2024 21:44
gtarpenning
gtarpenning approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the belated review, lgtm

@nicholaspun-wandb nicholaspun-wandb merged commit 83a22d7 into master Nov 15, 2024
113 of 115 checks passed
@nicholaspun-wandb nicholaspun-wandb deleted the npun-wb-16422-fe branch November 15, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gtarpenning gtarpenning gtarpenning approved these changes

@domphan-wandb domphan-wandb Awaiting requested review from domphan-wandb

Assignees

@nicholaspun-wandb nicholaspun-wandb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaspun-wandb @gtarpenning