chore(ui): create annotation specs #3003
Conversation
gtarpenning
changed the title
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=cc0c90f0ed0ea2c27e67e049f0b90f40fd00865c |
| Description: z.string().min(1), | ||
| Type: z.discriminatedUnion('type', [ | ||
| z.object({ | ||
| type: z.literal('boolean'), |
There was a problem hiding this comment.
you might want to capitalize Boolean (and other properties / literals) so that they render on the schema editor as such... depends on the display layer that you want.
There was a problem hiding this comment.
I honestly think it looks fine, because its not a label, it just gets rendered in the selector dropdown.
| size="small" | ||
| variant="ghost" | ||
| icon="delete" | ||
| tooltip="Remove this key" |
| /> | ||
| {fieldDescription && ( | ||
| <Box display="flex" alignItems="center" sx={{marginTop: '14px'}}> | ||
| <DescriptionTooltip description={fieldDescription} /> |
There was a problem hiding this comment.
this styling seems odd to me
There was a problem hiding this comment.
yeah because the icon gets centered in the whole div which is tall because of the TextFieldWithLabel being multi-line. We could add the description in TextFieldWithLabel but that breaks the pattern.
| }), | ||
| z.object({ | ||
| type: z.literal('enum'), | ||
| enum: z.array(z.string()).describe('List of options to choose from'), |
Description
https://wandb.atlassian.net/browse/WB-21665
Create annotation specs.
Testing
How was this PR tested?