chore(ui): create annotation specs #3003
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| import {Box} from '@material-ui/core'; | ||
| import React, {FC, useCallback, useState} from 'react'; | ||
| import {z} from 'zod'; | ||
|
|
||
| import {createBaseObjectInstance} from '../wfReactInterface/baseObjectClassQuery'; | ||
| import {TraceServerClient} from '../wfReactInterface/traceServerClient'; | ||
| import {sanitizeObjectId} from '../wfReactInterface/traceServerDirectClient'; | ||
| import {projectIdFromParts} from '../wfReactInterface/tsDataModelHooks'; | ||
| import {ScorerFormProps} from './ScorerForms'; | ||
| import {ZSForm} from './ZodSchemaForm'; | ||
|
|
||
| const AnnotationScorerFormSchema = z.object({ | ||
| Name: z.string().min(1), | ||
| Description: z.string().min(1), | ||
| Type: z.discriminatedUnion('type', [ | ||
| z.object({ | ||
| type: z.literal('boolean'), | ||
| }), | ||
| z.object({ | ||
| type: z.literal('number'), | ||
| min: z.number().optional().describe('Optional minimum value'), | ||
| max: z.number().optional().describe('Optional maximum value'), | ||
| }), | ||
| z.object({ | ||
| type: z.literal('string'), | ||
| max_length: z | ||
| .number() | ||
| .optional() | ||
| .describe('Optional maximum length of the string'), | ||
| }), | ||
| z.object({ | ||
| type: z.literal('enum'), | ||
| enum: z.array(z.string()).describe('List of options to choose from'), | ||
|
|
||
| }), | ||
| ]), | ||
| }); | ||
|
|
||
| export const AnnotationScorerForm: FC< | ||
| ScorerFormProps<z.infer<typeof AnnotationScorerFormSchema>> | ||
| > = ({data, onDataChange}) => { | ||
| const [config, setConfig] = useState(data); | ||
| const [isValid, setIsValid] = useState(false); | ||
|
|
||
| const handleConfigChange = useCallback( | ||
| (newConfig: any) => { | ||
| setConfig(newConfig); | ||
| onDataChange(isValid, newConfig); | ||
| }, | ||
| [isValid, onDataChange] | ||
| ); | ||
|
|
||
| const handleValidChange = useCallback( | ||
| (newIsValid: boolean) => { | ||
| setIsValid(newIsValid); | ||
| onDataChange(newIsValid, config); | ||
| }, | ||
| [config, onDataChange] | ||
| ); | ||
|
|
||
| return ( | ||
| <Box> | ||
| <ZSForm | ||
| configSchema={AnnotationScorerFormSchema} | ||
| config={config ?? {}} | ||
| setConfig={handleConfigChange} | ||
| onValidChange={handleValidChange} | ||
| /> | ||
| </Box> | ||
| ); | ||
| }; | ||
|
|
||
| export const onAnnotationScorerSave = async ( | ||
| entity: string, | ||
| project: string, | ||
| data: z.infer<typeof AnnotationScorerFormSchema>, | ||
| client: TraceServerClient | ||
| ) => { | ||
| let type = data.Type.type; | ||
| if (type === 'enum') { | ||
| type = 'string'; | ||
| } | ||
| return createBaseObjectInstance(client, 'AnnotationSpec', { | ||
| obj: { | ||
| project_id: projectIdFromParts({entity, project}), | ||
| object_id: sanitizeObjectId(data.Name), | ||
| val: { | ||
| name: data.Name, | ||
| description: data.Description, | ||
| json_schema: { | ||
| ...data.Type, | ||
| type, | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to capitalize Boolean (and other properties / literals) so that they render on the schema editor as such... depends on the display layer that you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly think it looks fine, because its not a label, it just gets rendered in the selector dropdown.