-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name not being passed into discovery.createCollection( #457
Comments
I suspect you're right, can you send a PR with the change and a test? |
Yes I can. I would propose the change to
would that be OK ? |
Yep. Make sure the JSDoc is also updated |
chughts
added a commit
to chughts/node-sdk
that referenced
this issue
May 21, 2017
…on name as name parameter
4 tasks
nfriedly
added a commit
that referenced
this issue
May 22, 2017
Fix for #457 Collection Name Parameter for create collection [semver patch]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If this is a usage problem, then let me know and I will post a question in the appropriate forum, but I have had a look and I think that its a problem with the SDK.
The discovery.createCollection builds the body for the underlying REST API as
body: JSON.stringify(pick(params, ['collection_name', 'description', 'configuration_id', 'language_code']))
but the API is expecting a body of
which means that
name
is never getting set. So every time I try to invoke the method through the SDK I getThe text was updated successfully, but these errors were encountered: