Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #457 Collection Name Parameter for create collection #460

Merged
merged 3 commits into from
May 22, 2017

Conversation

chughts
Copy link
Member

@chughts chughts commented May 21, 2017

Fix for issue #457 in SDK for Discovery service. Service expects Collection Name for the Create Collection method to be passed in as body.name. The SDK was sending it in as body.collection_name.

Code has been fixed.
JSDoc param has been updated.
Unit Text created.
Integration test has been fixed.

Checklist (Is this checklist for you or for me?)
  • npm test passes (tip: npm run autofix can correct most style issues)
  • tests are included
  • documentation is changed or added
  • link to public docs when adding new a service or new features for an existing service

@CLAassistant
Copy link

CLAassistant commented May 21, 2017

CLA assistant check
All committers have signed the CLA.

@nfriedly nfriedly merged commit 81d99c6 into watson-developer-cloud:master May 22, 2017
@nfriedly
Copy link
Contributor

Merged, should be released by CI shortly. Do you know if the old name ever worked, or was this broken from the start?

@chughts
Copy link
Member Author

chughts commented May 22, 2017

I think broken from the start.

@chughts chughts deleted the 457fix branch May 22, 2017 13:36
@nfriedly
Copy link
Contributor

OK, thanks.

Oh, and the checklist is for you, basically a list of things I'll probably ask for if they aren't included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants