Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java-Repository is no longer beeing installed when java is not needed #45

Conversation

madonius
Copy link

@madonius madonius commented Aug 8, 2018

The java repository was installed even if the isntallation of java was beeing skipped by the user in the elastic search and logstash repository

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
… installed
@cadoming cadoming self-requested a review October 24, 2018 09:42
Copy link
Contributor

@cadoming cadoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

@madonius, first of all, thank you for your colaboration. I test your request and it works but there is a small indent typo in the elasticsearch ansible-role-elasticsearch/task/Debian.yml:

 - name: Debian/Ubuntu | Oracle Java 8 installer
       apt:
         name: oracle-java8-installer
         state: present
         cache_valid_time: 3600
       tags: install

There is an extra blank space.

You can do the commit your self or we could create a new branch from yours branch we would do the commit and after the PR, whatever you want.

Regards.
Carlos

@madonius
Copy link
Author

Hey @cadoming,
thanks for your feedback, the blank space was missing with the others, where the - was in column 4 instead of column 5.

Fix is coming right now :)

@cadoming
Copy link
Contributor

Thank you @madonius for your contribution, we are going to use a new structure (branch 3.7) from now so I created a new PR with your changes #73 addapted to that structure.

@cadoming cadoming closed this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants