Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve of the Java repository #73

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Improve of the Java repository #73

merged 1 commit into from
Nov 2, 2018

Conversation

cadoming
Copy link
Contributor

This is the PR made to add your suggestions that the @madonius made in the PR #45 , with the only diference that is addapted for the new branch 3.7

@cadoming cadoming changed the title test Improve of the Java repository Oct 30, 2018
@cadoming cadoming mentioned this pull request Oct 31, 2018
Closed
SitoRBJ
SitoRBJ approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@SitoRBJ SitoRBJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cadoming, @madonius.

We have run tests with the PR branch and they have been successful. We proceed to merge the code. Thank you.

Regards,

Alfonso

@SitoRBJ SitoRBJ merged commit c9251be into 3.7 Nov 2, 2018
@SitoRBJ SitoRBJ deleted the Java-Repository-3.7-PR branch November 2, 2018 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SitoRBJ SitoRBJ SitoRBJ approved these changes

@jesuslinares jesuslinares Awaiting requested review from jesuslinares

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cadoming @SitoRBJ